Skip to content

Conversation

shihaonan369
Copy link
Contributor

@shihaonan369 shihaonan369 commented Apr 30, 2020

Describe the pull request
Fix nuget package import failed.

@LilyWangL LilyWangL requested review from Cheney-W and strega-nil May 6, 2020 01:54
@PhoebeHui PhoebeHui changed the title Fix nuget package import failed. [vcpkg] Fix nuget package import failed. May 6, 2020
@Cheney-W Cheney-W marked this pull request as ready for review May 6, 2020 08:52
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label May 6, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

Hey @ras0219-msft, does this look correct? I don't know anything about nuget, unfortunately.

@strega-nil strega-nil removed their request for review May 11, 2020 21:45
@dan-shaw dan-shaw merged commit 4727bc8 into microsoft:master May 14, 2020
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
* fix bug that caused exported nuget package import failure.

* Give priority to nuget package to set $(VcpkgRoot).

* [vcpkg] Remove trailing whitespace

* fix nuget package import failed

Co-authored-by: 施浩男 <[email protected]>
Co-authored-by: Robert Schumacher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuGet package doesn't add proper include and library paths
5 participants