Skip to content

Conversation

AlexAltea
Copy link
Contributor

No description provided.

@AlexAltea AlexAltea force-pushed the freerdp-update branch 2 times, most recently from d204204 to 8384ee5 Compare April 27, 2020 11:22
@LilyWangL LilyWangL requested a review from JackBoosY April 28, 2020 03:01
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following files are placed in
C:\agent\_work\1\s\packages\freerdp_x64-windows-static:

    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/audin-client-winmm.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/audin-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/cliprdr-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/disp-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/drdynvc-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/drive-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/echo-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/encomsp-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/geometry-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/printer-client-win.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/printer-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/rail-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/rdp2tcp-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/rdpdr-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/rdpei-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/rdpgfx-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/rdpsnd-client-fake.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/rdpsnd-client-winmm.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/rdpsnd-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/remdesk-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/smartcard-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/urbdrc-client-libusb.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/urbdrc-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/video-client.lib

Files cannot be present in those directories.

The following files are placed in
C:\agent\_work\1\s\packages\freerdp_x64-windows-static\debug:

    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/audin-client-winmm.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/audin-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/cliprdr-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/disp-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/drdynvc-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/drive-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/echo-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/encomsp-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/geometry-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/printer-client-win.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/printer-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/rail-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/rdp2tcp-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/rdpdr-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/rdpei-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/rdpgfx-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/rdpsnd-client-fake.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/rdpsnd-client-winmm.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/rdpsnd-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/remdesk-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/smartcard-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/urbdrc-client-libusb.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/urbdrc-client.lib
    C:/agent/_work/1/s/packages/freerdp_x64-windows-static/debug/video-client.lib

Files cannot be present in those directories.

Signed-off-by: Alexandro Sanchez Bach <[email protected]>
@AlexAltea
Copy link
Contributor Author

AlexAltea commented May 5, 2020

@JackBoosY Fixed!

For some reason, temporary objects were being stored in those directories, while the final library files (as expected) got saved to /lib and /debug/lib. I've removed those unnecessary files under if the VCPKG_LIBRARY_LINKAGE is static.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label May 6, 2020
@strega-nil
Copy link
Contributor

LGTM! Thanks @AlexAltea :)

@strega-nil strega-nil merged commit 4b7d4f5 into microsoft:master May 8, 2020
@AlexAltea AlexAltea deleted the freerdp-update branch May 13, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants