[libvpx] Added support for build on MacOS and Linux #11022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I got error "There are no build logs for libvpx build. bla bla bla" for the "vcpkg-osx-PR-test" But everything was built fine. Can you please help me with understanding and fixing the problem? |
|
Thanks for your PR. Could you please remove the following codes in scripts/ci.baseline.txt, it makes Linux and MACOS build failed. |
|
Done! Thank you for your prompt! |
LilyWangL
added
info:reviewed
LilyWangL
approved these changes
Apr 28, 2020
|
@kafeg would you mind resolving the merge conflict? otherwise, this looks great, and I'd love to merge it :) |
|
Hey @strega-nil ! Thank you for remind ;) |
|
Hello @strega-nil? Is everything ok? Could you merge this, please? 🙏 |
|
Yep, I just somehow missed it in my notifications, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Added support for build libvpx on Mac and Linux
x64-linux, x64-osx