Skip to content

Conversation

BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Apr 23, 2020

  • Adds scripts to generate scale sets for testing Linux.
  • Switches Windows validation to 'Spot' VMs.
  • Opens the git port 9418.
  • Removes provisioning of the no longer used 'logs' file share.
  • Changes Azure region to 'westus2', which is cheaper.
  • Adds +x to all the scripts in scripts/azure-pipelines.
  • Use 'xml-results' for all platforms instead of 'raw xml results' on Windows.

@BillyONeal BillyONeal self-assigned this Apr 23, 2020
@BillyONeal BillyONeal marked this pull request as draft April 23, 2020 09:53
@LilyWangL LilyWangL requested a review from ras0219-msft April 23, 2020 10:02
@LilyWangL LilyWangL requested a review from JackBoosY April 23, 2020 10:02
@LilyWangL LilyWangL changed the title Onboard Linux VMSS. [vcpkg] Onboard Linux VMSS. Apr 23, 2020
@BillyONeal BillyONeal force-pushed the vmss_linux branch 3 times, most recently from ddd65f9 to 3de77c8 Compare April 24, 2020 09:08
@BillyONeal
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal BillyONeal force-pushed the vmss_linux branch 3 times, most recently from 31c6854 to d254bb6 Compare April 26, 2020 02:16
@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@BillyONeal
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal BillyONeal force-pushed the vmss_linux branch 2 times, most recently from 777cd96 to 80f1c23 Compare April 28, 2020 22:11
@BillyONeal BillyONeal changed the title [vcpkg] Onboard Linux VMSS. [vcpkg] Onboard Linux to VMSS, open 'git' port, and switch back to Azure Spot Apr 29, 2020
@BillyONeal BillyONeal marked this pull request as ready for review April 29, 2020 05:19
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just got some minor suggestions and questions :)

Also, what's going on with analyze-test-results.ps1 and generate-skip-list.ps1? they have different permissions now, maybe? is there a reason for that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably use a git hash

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the diff here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably trailing whitespace VS Code automatically deleted when I saved the change :/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the diff here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto probably trailing whitespace

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the diff here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto trailing whitespace

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably trailing whitespace VS Code automatically deleted when I saved the change :/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto probably trailing whitespace

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto trailing whitespace

@BillyONeal
Copy link
Member Author

Also, what's going on with analyze-test-results.ps1 and generate-skip-list.ps1? they have different permissions now, maybe? is there a reason for that?

chmod +x :)

…ure Spot

* Adds scripts to generate scale sets for testing Linux.
    * Note workaround for microsoft/azure-pipelines-agent#2929
* Switches Windows validation to 'Spot' VMs.
* Opens the git port 9418.
* Removes provisioning of the no longer used 'logs' file share.
* Changes Azure region to 'westus2', which is cheaper.
* Adds +x to all the scripts in scripts/azure-pipelines.
* Use 'xml-results' for all platforms instead of 'raw xml results' on Windows.
@BillyONeal BillyONeal force-pushed the vmss_linux branch 2 times, most recently from 43bafca to 50a6e6a Compare May 1, 2020 03:28
@BillyONeal BillyONeal merged commit 28fc76e into microsoft:master May 1, 2020
@BillyONeal BillyONeal deleted the vmss_linux branch May 1, 2020 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants