Skip to content

Conversation

LazyWolfLin
Copy link
Contributor

[gtest] Rollback to a release version 1.10.0. Related issue #9768.

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

@strega-nil

Could you please help take a look at what happened on azure-kinect-sensor-sdk?

I have tried several ways to deal with this regression, such as remove tombstone, re run, run failed job, but it still doesn't work now.

optimized;C:/agent/_work/1/s/installed/x64-windows/lib/jpeg.lib;debug;C:/agent/_work/1/s/installed/x64-windows/debug/lib/jpegd.lib (found version "62") 
-- Looking for pthread.h
-- Looking for pthread.h - not found
-- Found Threads: TRUE  
CMake Error at CMakeLists.txt:171 (configure_file):
  configure_file Problem configuring file

@JackBoosY
Copy link
Contributor

Should we really need to rollback gtest version?

@strega-nil
Copy link
Contributor

Probably it makes sense to roll back; we should be using released versions if they exist.

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

It seems that it has passed on microsoft.vcpkg.pr(x64-windows).
Does this mean that it has passed on all triplets in CI?
Could you please help confirm if our CI detection has been changed to microsoft.vcpkg.pr currently instead of microsoft.vcpkg?

Thanks.

@strega-nil
Copy link
Contributor

@NancyLi1013 yeah, microsoft.vcpkg.pr is the new CI that we need to pass

@strega-nil
Copy link
Contributor

Looks good to me! Thanks @LazyWolfLin :)

@strega-nil strega-nil merged commit aa0b9d7 into microsoft:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants