Skip to content

Conversation

ctabin
Copy link
Contributor

@ctabin ctabin commented Apr 18, 2020

Uses libzippp last release tag instead of some commit on the master.

@msftclas
Copy link

msftclas commented Apr 18, 2020

CLA assistant check
All CLA requirements met.

@ctabin ctabin force-pushed the update-libzippp branch 2 times, most recently from 51c79a9 to dec0dfb Compare April 18, 2020 12:56
@ctabin ctabin changed the title Update to libzippp-v3.1-1.6.1 [libzippp] Update to libzippp-v3.1-1.6.1 Apr 18, 2020
@ctabin ctabin force-pushed the update-libzippp branch 2 times, most recently from 502eb3d to 6a8d00d Compare April 18, 2020 13:10
@ctabin
Copy link
Contributor Author

ctabin commented Apr 18, 2020

It seems there is a problem with the otl library in the failed checks:

-- Using cached C:/vsts/_work/4/s/downloads/otlv4_40451.zip
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:99 (message):
  

  File does not have expected hash:

          File path: [ C:/vsts/_work/4/s/downloads/otlv4_40451.zip ]
      Expected hash: [ add1e54fae20175461d5f09cbe324e98b6f6a3839356136811109cf3251ca96541c101816870c6cc15d7611ad6bf9d576ac8dfce4274419b30866955c5892d15 ]
        Actual hash: [ 74499b79a756c1ecc16d6bd9b277b91add55249d2e1cb65a31786e9750ff607da1222797f318954599efc5153cecee2d3a7fd1e994c09e7ddb2507c8e5ce5c55 ]

  Please delete the file and retry if this file should be downloaded again.

Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:110 (test_hash)
  ports/otl/portfile.cmake:3 (vcpkg_download_distfile)
  scripts/ports.cmake:90 (include)

It doesn't looks like libzippp related changes are implied here 🤔

@LilyWangL LilyWangL self-assigned this Apr 20, 2020
@LilyWangL
Copy link
Contributor

LilyWangL commented Apr 20, 2020

It seems there is a problem with the otl library in the failed checks:

-- Using cached C:/vsts/_work/4/s/downloads/otlv4_40451.zip
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:99 (message):
  

  File does not have expected hash:

          File path: [ C:/vsts/_work/4/s/downloads/otlv4_40451.zip ]
      Expected hash: [ add1e54fae20175461d5f09cbe324e98b6f6a3839356136811109cf3251ca96541c101816870c6cc15d7611ad6bf9d576ac8dfce4274419b30866955c5892d15 ]
        Actual hash: [ 74499b79a756c1ecc16d6bd9b277b91add55249d2e1cb65a31786e9750ff607da1222797f318954599efc5153cecee2d3a7fd1e994c09e7ddb2507c8e5ce5c55 ]

  Please delete the file and retry if this file should be downloaded again.

Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:110 (test_hash)
  ports/otl/portfile.cmake:3 (vcpkg_download_distfile)
  scripts/ports.cmake:90 (include)

It doesn't looks like libzippp related changes are implied here 🤔

It's not related with this PR, waitting for other PR fix CI error.

@ctabin
Copy link
Contributor Author

ctabin commented Apr 20, 2020

@LilyWangL I updated the files according to your suggestions. Back to you 👍

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Apr 21, 2020
@ras0219-msft ras0219-msft merged commit 54b9849 into microsoft:master Apr 21, 2020
@ras0219-msft
Copy link
Collaborator

Thanks for the PR!

@ctabin ctabin deleted the update-libzippp branch September 19, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants