Skip to content

[skyr-url] Bump version to 1.7.0 #10868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2020
Merged

[skyr-url] Bump version to 1.7.0 #10868

merged 2 commits into from
Apr 21, 2020

Conversation

glynos
Copy link
Contributor

@glynos glynos commented Apr 16, 2020

Describe the pull request

  • What does your PR fix? Fixes issue #

Updates version of skyr-url, including additional features

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    x64-osx, x64-linux, x64-windows

  • Does your PR follow the maintainer guide?

@NancyLi1013 NancyLi1013 self-assigned this Apr 17, 2020
@NancyLi1013
Copy link
Contributor

Hi @glynos
Thanks for this PR.
Could you please look into the regressions on x64-windows-static triplet?

-- Found nlohmann_json: C:/vsts/_work/3/s/installed/x64-windows-static/share/nlohmann_json/nlohmann_jsonConfig.cmake (found version "3.7.3") 
CMake Error at src/CMakeLists.txt:6 (configure_file):
  configure_file Problem configuring file

NancyLi1013
NancyLi1013 suggested changes Apr 17, 2020
View reviewed changes
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Apr 20, 2020
@ras0219-msft ras0219-msft merged commit 1c3cab4 into microsoft:master Apr 21, 2020
@ras0219-msft
Copy link
Collaborator

Thanks for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@NancyLi1013 NancyLi1013

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glynos @NancyLi1013 @ras0219-msft