[protobuf] Update to 3.11.4 #10863
Merged
[protobuf] Update to 3.11.4 #10863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. Could you use vcpkg_check_features() to handle feature in portfile.cmake L35? |
LilyWangL
suggested changes
Apr 20, 2020
|
I made the proper changes, but it looks like it's still listed as 'Waiting for response'. Just wanted to check if there is any other action i need to take to get this reviewed. Thanks! |
|
I see it the pipeline failed on windows ARM. Though, I can't find any literature anywhere that claims that Protobuf actually supports ARM. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
LilyWangL
added
info:reviewed
|
LGTM, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Simple update to Protobuf, updating it from 3.11.3 to 3.11.4
What does your PR fix? Fixes issue #
Updates Google-Protobuf from 3.11.3 to 3.11.4
Which triplets are supported/not supported? Have you updated the CI baseline?
Unchanged from supported protobuf triplets
Does your PR follow the maintainer guide?
Yes!