Skip to content

[c4core] Add new port #10791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 17, 2020
Merged

[c4core] Add new port #10791

merged 9 commits into from
Apr 17, 2020

Conversation

vvandrounik
Copy link
Contributor

@vvandrounik vvandrounik commented Apr 12, 2020 •
edited
Loading

Describe the pull request

  • What does your PR fix?
    N/A
  • Which triplets are supported/not supported? Have you updated the CI baseline?
    Tested (locally): x64/x86-linux, x64/x86-windows (static linkage only).
    No.
  • Does your PR follow the maintainer guide?
    Yes.

@msftclas
Copy link

msftclas commented Apr 12, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

JackBoosY
JackBoosY suggested changes Apr 13, 2020
View reviewed changes
@JackBoosY
Copy link
Contributor

Plesae ignore boost-asio and argumentum regressions, they are not related with this PR.

JackBoosY
JackBoosY suggested changes Apr 13, 2020
View reviewed changes
@JackBoosY
Copy link
Contributor

On x64-osx:

CMake Error at cmake/c4Project.cmake:1661 (message):
  not implemented
Call Stack (most recent call first):
  CMakeLists.txt:75 (c4_install_exports)

Is this expected?

JackBoosY
JackBoosY suggested changes Apr 14, 2020
View reviewed changes
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels Apr 15, 2020
@JackBoosY
Copy link
Contributor

LGTM.

@vvandrounik
Copy link
Contributor Author

@JackBoosY Thanks for helping

@LilyWangL LilyWangL mentioned this pull request Apr 16, 2020
Merged
ras0219-msft
ras0219-msft requested changes Apr 16, 2020
View reviewed changes
@ras0219-msft ras0219-msft merged commit 7d2f838 into microsoft:master Apr 17, 2020
@ras0219-msft
Copy link
Collaborator

Thanks for the PR!

@vvandrounik vvandrounik deleted the c4core branch April 19, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft requested changes

+1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@JackBoosY JackBoosY

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vvandrounik @msftclas @JackBoosY @ras0219-msft