Skip to content

[simdjson] Update to 0.3.1 #10709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
May 27, 2020
Merged

[simdjson] Update to 0.3.1 #10709

merged 23 commits into from
May 27, 2020

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Apr 6, 2020 •
edited
Loading

Describe the pull request

It seems that simdjson supports arm64 now.

@PhoebeHui PhoebeHui self-assigned this Apr 7, 2020
PhoebeHui
PhoebeHui requested changes Apr 7, 2020
View reviewed changes
@NancyLi1013 NancyLi1013 mentioned this pull request Apr 8, 2020
Closed
@PhoebeHui
Copy link
Contributor

simdjson:x64-uwp failed on CI testing, could you please have a look?

@myd7349 myd7349 mentioned this pull request May 13, 2020
Closed
@myd7349 myd7349 force-pushed the simdjson-v0.3.1 branch from d9c60f7 to 683d3e0 Compare May 21, 2020 06:55
@myd7349 myd7349 mentioned this pull request May 22, 2020
Merged
@myd7349 myd7349 marked this pull request as ready for review May 22, 2020 03:21
@myd7349
Copy link
Contributor Author

myd7349 commented May 22, 2020 •
edited
Loading

simdjson:x64-uwp failed on CI testing, could you please have a look?

Hi! @PhoebeHui Sorry for the long delay. I think I have finished this PR.

PhoebeHui
PhoebeHui approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your updates!

@PhoebeHui PhoebeHui added category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 22, 2020
@dan-shaw
Copy link
Contributor

LGTM, thanks @myd7349. Just merged another simdjson PR, could you resolve the conflicts?

@myd7349
Copy link
Contributor Author

myd7349 commented May 27, 2020 •
edited
Loading

Hi! @dan-shaw I have resolved the conflicts. By specifing -DSIMDJSON_SANITIZE=OFF, the Fix-error-LNK2001.patch patch isn't necessary any more.

@dan-shaw dan-shaw merged commit ea07b5d into microsoft:master May 27, 2020
@myd7349 myd7349 deleted the simdjson-v0.3.1 branch May 27, 2020 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

+1 more reviewer

@dan-shaw dan-shaw dan-shaw approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@PhoebeHui PhoebeHui

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid link library for port simdjson found by find_library.
3 participants
@myd7349 @PhoebeHui @dan-shaw