Skip to content

Conversation

LilyWangL
Copy link
Contributor

Describe the pull request
Fix nuget/aria2/ninja in vcpkgTools.xml, vcpkg_find_acquire_program.cmake version/filename inconsistent

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui PhoebeHui marked this pull request as ready for review April 2, 2020 06:51
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Apr 2, 2020
@MVoz
Copy link
Contributor

MVoz commented Apr 2, 2020

https://github.com/ninja-build/ninja/releases

ninja v1.10.0 released this on 28 Jan

?

@LilyWangL
Copy link
Contributor Author

https://github.com/ninja-build/ninja/releases

ninja v1.10.0 released this on 28 Jan

?

This PR fix issue #10655. Ninja will update to new version by other PRs.

@MVoz
Copy link
Contributor

MVoz commented Apr 3, 2020

why you can't update the version right away, what are the difficulties in this?

@dan-shaw
Copy link
Contributor

dan-shaw commented Apr 6, 2020

Going to merge this to fix the immediate issue. For updating Ninja, we can open another PR

@dan-shaw dan-shaw merged commit 6c4e822 into microsoft:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants