Skip to content

Conversation

glynos
Copy link
Contributor

@glynos glynos commented Mar 18, 2020

This port is for Skyr URL, and corresponds to issue #10462

@msftclas
Copy link

msftclas commented Mar 18, 2020

CLA assistant check
All CLA requirements met.

@dan-shaw
Copy link
Contributor

/azp run

@LilyWangL LilyWangL changed the title Add port for Skyr URL library [skyr-url] Add new port Mar 24, 2020
@LilyWangL
Copy link
Contributor

/azp run

@LilyWangL
Copy link
Contributor

@glynos Thanks for your PR. This port build failed on CI test. You can click the Detail to get the error log on CI test. Could you continue to fix this PR?

@glynos
Copy link
Contributor Author

glynos commented Mar 28, 2020

Hello,

The only remaining error I need to fix is described in this log:

/ci/myagent/_work/1/s/buildtrees/skyr-url/install-x64-linux-dbg-out.log

in the "test modified ports" step. Could you tell me how I can access that?

Many thanks for your help.

@LilyWangL
Copy link
Contributor

You can click 1 artifact to get the error log as below:
image

@glynos
Copy link
Contributor Author

glynos commented Mar 30, 2020

Thanks for all your help. I've updated my own code, but now the CI failures all seem to be coming from another library that I don't control:

https://dev.azure.com/vcpkg/public/_build/results?buildId=32447&view=logs&j=275f1d19-1bd8-5591-b06b-07d489ea915a&t=a4822bc1-f3a9-5984-c941-6c1b7aa2ab81&l=18

@LilyWangL
Copy link
Contributor

Thanks for all your help. I've updated my own code, but now the CI failures all seem to be coming from another library that I don't control:

https://dev.azure.com/vcpkg/public/_build/results?buildId=32447&view=logs&j=275f1d19-1bd8-5591-b06b-07d489ea915a&t=a4822bc1-f3a9-5984-c941-6c1b7aa2ab81&l=18

It is not a related error with this PR. This is CI baseline issue, the related PR #10603.

@glynos
Copy link
Contributor Author

glynos commented Mar 31, 2020

Thanks for the explanation. What do I need to do for this PR? Wait until that one is fixed and try again?

@LilyWangL
Copy link
Contributor

/azp run

@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Apr 2, 2020
@dan-shaw dan-shaw merged commit 449adbe into microsoft:master Apr 3, 2020
@dan-shaw
Copy link
Contributor

dan-shaw commented Apr 3, 2020

Thanks for the PR!

@glynos glynos deleted the skyr_url branch April 3, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants