-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[geos] Upgrade to GEOS 3.6.4 #10377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[geos] Upgrade to GEOS 3.6.4 #10377
Conversation
c69c063
to
eae6f8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Just needs a slight change. Thanks so much :)
/azp run |
1 similar comment
/azp run |
@mwtoews @LilyWangL This is failing the CI for osg-qt. Do you know if this is a related error or an error with our CI? |
Port osg-qt build failed is not a related error with this PR. |
/azp run |
is this ready to merge yet? |
@ras0219-msft This PR is ready to merge. |
LGTM, thanks for this PR! |
Is GOES meant to be working? How is it meant to be used from CMake? See example from their project: https://git.osgeo.org/gitea/geos/geos/src/branch/master/examples/client/CMakeLists.txt This doesn't work with vcpkg (even when the version number is removed). It would be great if Vcpkg could tell the user when a package is installed if special instructions are needed for linking etc. |
Update port/geos to version 3.6.4, released 2019-10-04
See details in this release announcement
Note that this is not the current version, as I'd like to re-create each major version, so you can expect me to also create pull requests for GEOS versions 3.7.3 and 3.8.1 (current).