Improve x-test-features diagnostics for conflicting baseline entries #1663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deduplicate unexpected_states test. * Add a message when there are any failures.
…l enums rather than potentially leaking invalid enum class values to the caller.
…picks # Conflicts: # src/vcpkg/binarycaching.cpp
BillyONeal
commented
Apr 30, 2025
JavierMatosD
requested changes
May 1, 2025
Contributor
JavierMatosD
left a comment
JavierMatosD
left a comment
There was a problem hiding this comment.
Could you add a test so I can better understand what this does?
JavierMatosD
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare this before and after:
I still have more to improve in this output but this is a good starting place at the end of a Friday :)
Also fixed
tested-spec.txtbeing partially malformed due to a use-after-move I missed in #1650