Improve resiliency of concurrent use the downloads directory. #1600
Conversation
…, avoid getting exe path 3 times.
…rectory in configure-environment. Allows outright deletion of set_directory_to_archive_contents.
BillyONeal
changed the title
include/vcpkg/base/files.h
Outdated
| // | ||
| // If `old_path` and `new_path` resolve to the same file, the behavior is undefined. | ||
| bool rename_cas_like(const Path& old_path, const Path& new_path, std::error_code& ec) const; | ||
| bool rename_cas_like(const Path& old_path, const Path& new_path, LineInfo li) const; |
There was a problem hiding this comment.
cas? Maybe choose a different name 😅
There was a problem hiding this comment.
I considered something like xchg but that would imply the target is overwritten if it exists. I'm happy to use a different name but I don't have ideas for anything better.
There was a problem hiding this comment.
rename_to_or_delete_if_exists 😄
There was a problem hiding this comment.
I feel like that name is a bit too close to just 'putting the code entirely in the name' but when I don't feel strongly about things and someone felt strongly enough about it to make a comment, I'm going to apply the suggestion.
There was a problem hiding this comment.
How about rename_or_delete? The 'to' part is already implied by the rename, and avoids 'delete if exists' sounding like 'delete the target if it exists'. This way, one of those two verbs are clearly happening to the same subject (the source); we either rename the thing, or if we can't, we delete it.
This might workaround some failures reported by internal customers.