Connect the NO_PROXY environment variable to the WinHTTP backend to match the curl backend
#1598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@microsoft-github-policy-service agree |
BillyONeal
reviewed
Feb 20, 2025
BillyONeal
reviewed
Mar 20, 2025
| if (GetEnvironmentVariableW(L"HTTPS_PROXY", https_proxy_env, sizeof(https_proxy_env) / sizeof(wchar_t))) | ||
| { | ||
| access_type = WINHTTP_ACCESS_TYPE_NAMED_PROXY; | ||
| proxy_setting = https_proxy_env; | ||
| proxy_bypass_setting = L"<local>"; |
There was a problem hiding this comment.
I observe tls12-download said <local> while the main product said nullptr; I think x-download is more widely used and thus want to resolve conflicts in favor of it, so I changed this one to nullptr.
BillyONeal
approved these changes
Mar 20, 2025
BillyONeal
changed the title
NO_PROXY environment variable to the WinHTTP backend to match the curl backend
ras0219-msft
approved these changes
Mar 20, 2025
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for bypass list in proxy.
Now vcpkg ignores this setting, and it is real problem in corporate networks behind proxy.
Especially with mixed environments: some packages are public, some are private.
In Windows I turned on WPAD for WinHTTP.
In Linux I added "no_proxy" element to be passed to curl.