Skip to content

Unable to read error message from response header #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Unable to read error message from response header #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be84882
Added response headers to err answer
Roman-Shchukin Sep 13, 2022
a011c93
Corrected message in test
Roman-Shchukin Sep 14, 2022
7faf417
Corrected package version
Roman-Shchukin Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/RestClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,10 @@ export class RestClient {
err['result'] = response.result;
}

if (response.headers) {
err['responseHeaders'] = response.headers;
}

reject(err);
} else {
resolve(response);
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "typed-rest-client",
"version": "1.8.10",
"version": "1.8.11",
"description": "Node Rest and Http Clients for use with TypeScript",
"main": "./RestClient.js",
"scripts": {
Expand Down
26 changes: 13 additions & 13 deletions test/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions test/tests/resttests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ describe('Rest Tests', function () {
catch(err) {
assert(err['statusCode'] == 401, "statusCode should be 401");
assert(err.message && err.message.length > 0, "should have error message");
assert(err['responseHeaders'], "err must contain responseHeaders");
}
});

Expand All @@ -237,6 +238,7 @@ describe('Rest Tests', function () {
catch(err) {
assert(err['statusCode'] == 500, "statusCode should be 500");
assert(err.message && err.message.length > 0, "should have error message");
assert(err['responseHeaders'], "err must contain responseHeaders");
}
});

Expand Down