Skip to content

Conversation

Evangelink
Copy link
Member

@Evangelink Evangelink commented Jul 23, 2025

Blocked on arcade's insertion. Unblocked with #6145

Fixes #6098

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.87%. Comparing base (b2570d4) to head (2f20611).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6140      +/-   ##
==========================================
- Coverage   76.90%   76.87%   -0.04%     
==========================================
  Files         619      619              
  Lines       37654    37654              
==========================================
- Hits        28959    28946      -13     
- Misses       8695     8708      +13     
Flag Coverage Δ
Debug 76.87% <ø> (-0.04%) ⬇️
integration 76.87% <ø> (-0.04%) ⬇️
production 76.87% <ø> (-0.04%) ⬇️
unit 76.86% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Youssef1313
Copy link
Member

Arcade is now flowing again #6145 🎉

@Youssef1313
Copy link
Member

Merged latest main and temporarily switching public CI to Arcade so that we test the changes here and avoid the risk of breaking official builds.

@Youssef1313
Copy link
Member

Waiting on dotnet/arcade#15996 :/

@Youssef1313
Copy link
Member

Youssef1313 commented Jul 24, 2025

PLEASE LET'S AVOID PUSHING OR RESTARTING CI HERE FOR NOW safe to push now ;)

@Youssef1313
Copy link
Member

  Unhandled Exception: System.InvalidOperationException: Failed to flush logs before the timeout of '90' seconds
     at Microsoft.Testing.Platform.Logging.FileLogger.Dispose()
     at Microsoft.Testing.Platform.Logging.FileLoggerProvider.Dispose()
     at Microsoft.Testing.Platform.Helpers.DisposeHelper.<DisposeAsync>d__0.MoveNext()
  --- End of stack trace from previous location where exception was thrown ---
     at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
     at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
     at System.Runtime.CompilerServices.ConfiguredTaskAwaitable.ConfiguredTaskAwaiter.GetResult()
     at Microsoft.Testing.Platform.Hosts.CommonHost.<RunAsync>d__8.MoveNext()
  --- End of stack trace from previous location where exception was thrown ---
     at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
     at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
     at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
     at Microsoft.Testing.Platform.Builder.TestApplication.<RunAsync>d__10.MoveNext()
  --- End of stack trace from previous location where exception was thrown ---
     at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
     at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
     at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
     at Program.<<Main>$>d__0.MoveNext()
  --- End of stack trace from previous location where exception was thrown ---
     at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
     at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
     at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
     at Program.<Main>(String[] args)

It seems to be happening only for MSTest.Analyzers.UnitTests (net462) so far.

@Youssef1313
Copy link
Member

I triggered a re-run. It's likely flakiness but it's hard to say if it's one-off or if it will be frequent.

Youssef1313
Youssef1313 previously approved these changes Jul 26, 2025
@Youssef1313 Youssef1313 marked this pull request as ready for review July 26, 2025 09:22
@Youssef1313 Youssef1313 marked this pull request as draft July 26, 2025 09:22
@Youssef1313 Youssef1313 marked this pull request as ready for review July 28, 2025 08:40
@Youssef1313 Youssef1313 merged commit 0cac9ba into main Jul 28, 2025
8 checks passed
@Youssef1313 Youssef1313 deleted the dev/amauryleve/arcade branch July 28, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove our custom TestingPlatformRunner.targets and rely on existing Arcade infra
4 participants