Skip to content

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented May 26, 2025

Fixes #5642

Instead of special casing MSTestDiscoverer.TestCategory and TestObject.Traits, we instead use TestPropertyAttributes.Trait to determine whether a property is a trait.

When the property value is string[], we assume it's the "categories". Otherwise, we expect it to be KVP<string, string>[] which is a list of traits as key value pairs.

NOTE: NUnit needs this. See nunit/nunit3-vs-adapter#1258

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.29%. Comparing base (310d17a) to head (4c13c92).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5644      +/-   ##
==========================================
- Coverage   76.34%   76.29%   -0.06%     
==========================================
  Files         602      602              
  Lines       36758    36754       -4     
==========================================
- Hits        28063    28041      -22     
- Misses       8695     8713      +18     
Flag Coverage Δ
Debug 76.29% <100.00%> (-0.06%) ⬇️
integration 76.29% <100.00%> (-0.05%) ⬇️
production 76.29% <100.00%> (-0.06%) ⬇️
unit 76.29% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
....VSTestBridge/ObjectModel/ObjectModelConverters.cs 92.11% <100.00%> (-0.19%) ⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Youssef1313
Copy link
Member Author

/backport to rel/3.9

Copy link
Contributor

@Youssef1313 Youssef1313 merged commit 892bce4 into main May 28, 2025
8 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/bridge-traits branch May 28, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VSTestBridge should handle TestPropertyAttributes.Trait

3 participants