[rel/3.9] Add missing overload for Assert.Throws #5620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Backport of support for interpolated string overloads in Assert.Throws to the rel/3.9 branch
- Introduces a new
AssertNonStrictThrowsInterpolatedStringHandlerconstructor that accepts aFunc<object?>action - Adds a
Throws<TException>(Func<object?>, handler)overload - Adds a unit test
Throws_WithInterpolationto verify overload resolution with interpolated strings
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.ThrowsExceptionTests.cs | Adds Throws_WithInterpolation test exercising the new overloads |
| src/TestFramework/TestFramework/Assertions/Assert.ThrowsException.cs | Adds handler constructor and Throws(Func<object?>, handler) overload |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
youssef-backport-bot
force-pushed
the
backport/5619/to/rel/3.9
branch
from
cb778d2 to
bfca717
Compare
Youssef1313
approved these changes
May 26, 2025
This was referenced Jul 22, 2025
This was referenced Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5619 to rel/3.9
/cc @Youssef1313