Skip to content

Conversation

Youssef1313
Copy link
Member

Hide whitespaces in diff for easier review.

This change basically still kills the test host even if writing the dump file fails, so that the process isn't stuck

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.38%. Comparing base (61be904) to head (d2ead67).

Files with missing lines Patch % Lines
...ensions.HangDump/HangDumpProcessLifetimeHandler.cs 86.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5538      +/-   ##
==========================================
+ Coverage   74.00%   76.38%   +2.38%     
==========================================
  Files         603      603              
  Lines       36419    36423       +4     
==========================================
+ Hits        26953    27823     +870     
+ Misses       9466     8600     -866     
Flag Coverage Δ
Debug 76.38% <86.66%> (+2.38%) ⬆️
integration 76.38% <86.66%> (+2.38%) ⬆️
production 76.38% <86.66%> (+2.38%) ⬆️
unit 76.38% <86.66%> (+2.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ensions.HangDump/HangDumpProcessLifetimeHandler.cs 80.19% <86.66%> (+26.24%) ⬆️

... and 61 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Youssef1313 Youssef1313 requested a review from nohwnd April 29, 2025 11:25
@nohwnd nohwnd merged commit 114d0cb into main Apr 29, 2025
8 checks passed
@nohwnd nohwnd deleted the dev/ygerges/kill-when-ex branch April 29, 2025 13:35
This was referenced Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants