Skip to content

Add descriptions and new labels to the bot rules #18342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 23, 2025
Merged

Add descriptions and new labels to the bot rules #18342

merged 5 commits into from
Apr 23, 2025

Conversation

@carlos-zamora
Copy link
Member

@carlos-zamora carlos-zamora commented Dec 19, 2024

Wanted to learn how the bot works, so I went ahead cleaned up the bot rules a bit. List of changes:

  • added a description for each rule (and move it to the top of the rule)
  • added all the "Area-" labels and sorted

If there's any new rules you'd like added, let me know. 🎁

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 19, 2024
View reviewed changes
.github/policies/resourceManagement.yml Outdated
label: Needs-Tag-Fix
description:
- if:
- description: Add "In-PR" label to isses that are referenced in a PR

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[isses](#security-tab) is not a recognized word. \(unrecognized-spelling\)
.github/policies/resourceManagement.yml Outdated
pattern: Impact-
description:
- if:
- description: Comments with "/dup", "/dupe", or "/duplicate" targetting another repo will close the issue as a duplicate and remove "Needs-" labels

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[targetting](#security-tab) is not a recognized word. \(unrecognized-spelling\)
DHowett
DHowett requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor spellbot concerns

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 21, 2025
lhecker
lhecker approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I don't understand what it is with the spellbot.

@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Jan 31, 2025
@carlos-zamora carlos-zamora removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. labels Jan 31, 2025
@carlos-zamora
Copy link
Member Author

carlos-zamora commented Jan 31, 2025

Well, the spellbot isn't complaining. Now it's just the GitOps/YmlValidation, but I'm having trouble finding anything on it and the error is not helpful. Hoping running the pipeline fixes it 🤷‍♂️. Any guidance is appreciated here.

/azp run

@mdanish-kh
Copy link
Contributor

mdanish-kh commented Mar 6, 2025

@carlos-zamora - My YAML parser is giving me an error with how the description: nodes are written out. This looks to be due to the fact the first 4 description nodes BEGIN with a double-quote " which the parser is interpreting as the first enclosing double-quote for the whole value & then gets confused where the string ends. Either you should enclose the string in single-quotes as '"Needs-Author-Feedback and No....."' or my preferred way would be to use YAML blocks always to not run into these sorts of issues

description: >-
  <text>

GIF:

yaml

@DHowett DHowett enabled auto-merge (squash) April 23, 2025 19:55
@DHowett
Copy link
Member

DHowett commented Apr 23, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 23, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@DHowett DHowett merged commit 093f5d1 into main Apr 23, 2025
19 of 21 checks passed
@DHowett DHowett deleted the dev/cazamor/bot-cleanup branch April 23, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

@lhecker lhecker lhecker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@carlos-zamora @mdanish-kh @DHowett @lhecker