Python: add stepwise planner #2223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave/semantic-kernel into python-add-stepwise-planner
TaoChenOSU
reviewed
Aug 7, 2023
awharrison-28
suggested changes
Aug 9, 2023
There was a problem hiding this comment.
Hi @joowon-dm-snu,
Thanks for porting stepwise planner to python SK. And thank for you identifying the bug in plan.py. I am going to cherry pick the plan.py change out to a separate PR and add a new test for it as it's needed downstream for something else.
python/semantic_kernel/planning/stepwise_planner/stepwise_planner.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/planning/stepwise_planner/stepwise_planner.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/planning/stepwise_planner/stepwise_planner.py
Outdated
Show resolved
Hide resolved
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
### Motivation and Context Initially called out and fixed by @joowon-dm-snu in #2223 This PR closes [#2094](#2094) There was a bug in the Plan Object Model that propagates the name of the step parameter to the next step. It should be propagating the parameter's value ### Description In addition to making the code change to fix the bug, also added a unit test that covers the changed code. Below image shows the before and after of the test with the fix.  ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 Co-authored-by: Abby Harrison <[email protected]>
mkarle
reviewed
Aug 15, 2023
mkarle
reviewed
Aug 15, 2023
python/semantic_kernel/planning/stepwise_planner/stepwise_planner.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/planning/stepwise_planner/stepwise_planner.py
Outdated
Show resolved
Hide resolved
python/tests/integration/planning/stepwise_planner/test_stepwise_planner.py
Show resolved
Hide resolved
python/semantic_kernel/planning/stepwise_planner/stepwise_planner_config.py
Show resolved
Hide resolved
python/semantic_kernel/planning/stepwise_planner/stepwise_planner.py
Outdated
Show resolved
Hide resolved
lemillermicrosoft
approved these changes
Aug 22, 2023
Rearranged the order of chat completion parameters in both `ChatRequestSettings` and `OpenAIChatCompletion` classes for better readability. Updated test cases to reflect these changes and added a new test case for stop sequences.
|
FYI @joowon-dm-snu I pushed a commit to fix the UTs. |
python/tests/integration/planning/stepwise_planner/test_stepwise_planner.py
Outdated
Show resolved
Hide resolved
awharrison-28
approved these changes
Aug 23, 2023
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
…#2388) ### Motivation and Context Initially called out and fixed by @joowon-dm-snu in microsoft#2223 This PR closes [microsoft#2094](microsoft#2094) There was a bug in the Plan Object Model that propagates the name of the step parameter to the next step. It should be propagating the parameter's value ### Description In addition to making the code change to fix the bug, also added a unit test that covers the changed code. Below image shows the before and after of the test with the fix.  ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 Co-authored-by: Abby Harrison <[email protected]>
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> implement stepwise planner microsoft#2221 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Abby Harrison <[email protected]> Co-authored-by: Lee Miller <[email protected]> Co-authored-by: Abby Harrison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
implement stepwise planner #2221
Description
Contribution Checklist