fix: make @react-native-community/cli optional #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package managers issue a warning when `@react-native-community/cli` isn't explicitly provided by consumers. We're making it optional because we can assume that it gets installed with react-native. If this changes, we will have to make changes anyway. This will suppress the warnings, and it will also avoid having to keep `@react-native-community/cli` aligned with the installed version of `react-native`.
kelset
approved these changes
Dec 6, 2021
This reverts commit a276db3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Package managers issue a warning when
@react-native-community/cliisn't explicitly provided by consumers. We're making it optional because we can assume that it gets installed with react-native. If this changes, we will have to make changes anyway.This will suppress the warnings, and it will also avoid having to keep
@react-native-community/clialigned with the installed version ofreact-native.Platforms affected
Test plan
n/a