Skip to content

fix(apple): allow platform deployment target to be overridden #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tido64 merged 1 commit into from
Oct 18, 2021
Merged

fix(apple): allow platform deployment target to be overridden #560

tido64 merged 1 commit into from
Oct 18, 2021

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Oct 18, 2021

Description

Allows users to override platform deployment target.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

Specifying deployment target should not fail pod install:

diff --git a/example/ios/Podfile b/example/ios/Podfile
index 03911b5..f46ebe0 100644
--- a/example/ios/Podfile
+++ b/example/ios/Podfile
@@ -1,3 +1,4 @@
+platform :ios, '14.0'
 require_relative '../node_modules/react-native-test-app/test_app'

 workspace 'Example.xcworkspace'

@tido64 tido64 requested review from kelset and tom-un October 18, 2021 09:35
@github-actions github-actions bot added platform: iOS This affects iOS platform: macOS This affects macOS labels Oct 18, 2021
@tido64 tido64 mentioned this pull request Oct 18, 2021
Merged
7 tasks
kelset
kelset approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@tido64 tido64 mentioned this pull request Oct 18, 2021
Merged
31 tasks
@tido64 tido64 added this to the 1.0 milestone Oct 18, 2021
@tido64 tido64 enabled auto-merge (squash) October 18, 2021 09:40
@tido64 tido64 merged commit 5a74110 into trunk Oct 18, 2021
@tido64 tido64 deleted the tido/consolidate-deployment-target branch October 18, 2021 09:54
@github-actions
Copy link

github-actions bot commented Oct 18, 2021

🎉 This PR is included in version 0.9.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tom-un tom-un Awaiting requested review from tom-un

1 more reviewer

@kelset kelset kelset approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform: iOS This affects iOS platform: macOS This affects macOS released

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tido64 @kelset