Skip to content

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Oct 16, 2021

Description

macOS test app fails to build after #553:

  • No account for team "UBF8T346G9". Add a new account in the Accounts preference pane or verify that your accounts have valid credentials.
  • No profiles for 'com.microsoft.ReactTestApp' were found: Xcode couldn't find any Mac App Development provisioning profiles matching 'com.microsoft.ReactTestApp'.

Reverts the code signing changes made to the macOS Xcode project, and adds the ability to configure code signing from the app manifest.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

  1. macOS test app should build again.
  2. Signing should work if configured correctly, e.g.
    diff --git a/example/app.json b/example/app.json
    index 8463354..557e1f1 100644
    --- a/example/app.json
    +++ b/example/app.json
    @@ -12,6 +12,12 @@
           "presentationStyle": "modal"
         }
       ],
    +  "macos": {
    +    "bundleIdentifier": "com.contoso.ReactTestApp",
    +    "codeSignEntitlements": "macos/Example.entitlements",
    +    "codeSignIdentity": "Apple Development",
    +    "developmentTeam": "UBF8T346G9"
    +  },
       "resources": {
         "android": [
           "dist/res",

Reverts the code signing changes made to the macOS Xcode project, and
adds the ability to configure code signing from the app manifest.
@tido64 tido64 requested a review from tom-un October 16, 2021 10:14
@github-actions github-actions bot added platform: iOS This affects iOS platform: macOS This affects macOS labels Oct 16, 2021
@tido64 tido64 added this to the 1.0 milestone Oct 16, 2021
@tido64 tido64 mentioned this pull request Oct 16, 2021
31 tasks
@tido64 tido64 merged commit 66f120f into trunk Oct 18, 2021
@tido64 tido64 deleted the tido/fix-macos-signing branch October 18, 2021 08:15
@github-actions
Copy link

🎉 This PR is included in version 0.9.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: iOS This affects iOS platform: macOS This affects macOS released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants