Skip to content

fix(windows): present React menu if no React view is loaded #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tido64 merged 1 commit into from
Oct 17, 2021
Merged

fix(windows): present React menu if no React view is loaded #522

tido64 merged 1 commit into from
Oct 17, 2021

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Sep 21, 2021

Description

Present "React" menu if no React view is currently loaded to educate users where to find apps.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

yarn
cd example
yarn install-windows-test-app --use-nuget
yarn windows

The test app should open the "React" menu when it starts up. Make sure the menu does not open when a view is opened on startup.

@github-actions github-actions bot added the platform: Windows This affects Windows label Sep 21, 2021
@tido64 tido64 mentioned this pull request Sep 21, 2021
Merged
31 tasks
@tido64 tido64 added this to the 1.0 milestone Sep 22, 2021
@tido64 tido64 marked this pull request as ready for review September 27, 2021 09:09
@tido64 tido64 requested a review from tom-un September 27, 2021 09:09
Base automatically changed from tido/auto-populate to trunk September 27, 2021 12:42
@tido64 tido64 requested a review from sweggersen September 27, 2021 12:44
@tido64 tido64 requested a review from afoxman October 13, 2021 19:25
@tido64 tido64 merged commit 396a8b7 into trunk Oct 17, 2021
@tido64 tido64 deleted the tido/open-flyout branch October 17, 2021 07:15
@github-actions
Copy link

github-actions bot commented Oct 17, 2021

🎉 This PR is included in version 0.9.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afoxman afoxman afoxman approved these changes

@tom-un tom-un Awaiting requested review from tom-un

@sweggersen sweggersen Awaiting requested review from sweggersen

Assignees

No one assigned

Labels

platform: Windows This affects Windows released

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tido64 @afoxman