Skip to content

Conversation

@acoates-ms
Copy link
Collaborator

When publishing from stable branches there is no step which removes the private flag from package.json. This means that the publish step fails.

This PR will ensure that we always remove the private flag and workspace info right before we publish the package.

We restore the original before we commit any version changes, otherwise removing the workspace config would break the workspace install.

@acoates-ms acoates-ms requested a review from alloy as a code owner October 27, 2021 00:08
@pull-bot
Copy link

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 0664214

@acoates-ms acoates-ms merged commit a186688 into microsoft:master Oct 28, 2021
@acoates-ms acoates-ms deleted the publishfixmaster branch September 2, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants