Skip to content

fix(chromium): make video recording duration close to real duration of the test run #38220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −1
Open

fix(chromium): make video recording duration close to real duration of the test run #38220

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9744944
fix(chromium): drop excessive screencast frames
Nov 14, 2025
f95e643
fix(chromium): round last frame timestamp to fps
Nov 14, 2025
62bae71
fix(chromium): add first frame delay in screencast
Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/playwright-core/src/server/chromium/videoRecorder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const fps = 25;
export class VideoRecorder {
private _process: ChildProcess | null = null;
private _gracefullyClose: (() => Promise<void>) | null = null;
private _launchTimestamp: number = 0;
private _lastWritePromise: Promise<void> = Promise.resolve();
private _lastFrameTimestamp: number = 0;
private _lastFrameBuffer: Buffer | null = null;
Expand Down Expand Up @@ -115,23 +116,31 @@ export class VideoRecorder {
});
this._process = launchedProcess;
this._gracefullyClose = gracefullyClose;
this._launchTimestamp = monotonicTime();
}

writeFrame(frame: Buffer, timestamp: number) {
assert(this._process);
if (this._isStopped)
return;

if (timestamp - this._lastFrameTimestamp < 1 / fps) {
this._lastFrameBuffer = frame;
return;
}

if (this._lastFrameBuffer) {
const durationSec = timestamp - this._lastFrameTimestamp;
const repeatCount = Math.max(1, Math.round(fps * durationSec));
for (let i = 0; i < repeatCount; ++i)
this._frameQueue.push(this._lastFrameBuffer);
this._lastWritePromise = this._lastWritePromise.then(() => this._sendFrames());
this._lastFrameTimestamp += repeatCount / fps;
} else {
this._lastFrameTimestamp = timestamp - (monotonicTime() - this._launchTimestamp) / 1000;
}

this._lastFrameBuffer = frame;
this._lastFrameTimestamp = timestamp;
this._lastWriteTimestamp = monotonicTime();
}

Expand Down