docs: improve testing library migration docs for within #37796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Really love playwright's component testing DX, some really nice improvements here! That being said I noticed this and thought that this would be a more realistic representation of what testing-lib users would do to query by test id. Signed-off-by: Chris O'Donnell <[email protected]>
Skn0tt
approved these changes
Oct 13, 2025
dgozman
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really love playwright's component testing DX, some really nice improvements here, ty!!
I read the testing library migration part of the docs and thought that this change would be a more realistic (and accurate?) representation of what testing-lib users would do to query by test id. I think technically it makes sense if the element you're querying actually has an
idproperty ofmessages, but I don't think the code comparison from TL -> Playwright here is 1-1.