Skip to content

chore: address some of the 1.56 api review feedback #37542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

chore: address some of the 1.56 api review feedback #37542

merged 1 commit into from
Sep 24, 2025

Conversation

@dgozman
Copy link
Contributor

@dgozman dgozman commented Sep 23, 2025

  • env.PLAYWRIGHT_LEGACY_SCREENSHOT
  • docs changes for new APIs

@dgozman
chore: address some of the 1.56 api review feedback
b8d212c 
- env.PLAYWRIGHT_LEGACY_SCREENSHOT
- docs changes for new APIs
@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2025

Test results for "tests 1"

2 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node18`

45484 passed, 816 skipped

Merge workflow run.

@dgozman dgozman merged commit ced088c into microsoft:main Sep 24, 2025
33 of 35 checks passed
This was referenced Sep 24, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yury-s yury-s yury-s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgozman @yury-s