chore(debug controller): add per-browser highlight + close #37061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Aug 28, 2025
| connectedBrowserFactory: async ({ wsEndpoint, browserType }, use) => { | ||
| const browsers: BrowserWithReuse [] = []; | ||
| await use(async () => { | ||
| await use(async launchOptions => { |
Contributor
There was a problem hiding this comment.
- I don't see
launchOptionsbeing used anywhere. - You probably want
{ ..._defaultLaunchOptions, ...launchOptions }instead.
Member
Author
There was a problem hiding this comment.
Hmm, I wonder why I added it 🤔 Will revert.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"2 failed 3 flaky46678 passed, 805 skipped Merge workflow run. |
Skn0tt
added a commit
to Skn0tt/playwright
that referenced
this pull request
Oct 1, 2025
…icrosoft#37061)" This reverts commit 78b498c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My UI will have per-browser buttons for picking a locator and closing a browser.