chore: publish browser list via DebugController #37027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Aug 14, 2025
packages/protocol/src/protocol.yml
Outdated
| items: | ||
| type: object | ||
| properties: | ||
| guid: string |
Contributor
There was a problem hiding this comment.
Let's call this id, because guid has a special meaning in the protocol.
| onPageOpen: () => this._emitSnapshot(false), | ||
| onPageOpen: page => { | ||
| this._emitSnapshot(false); | ||
| page.on(Page.Events.InternalFrameNavigatedToNewDocument, () => this._emitSnapshot(false)); |
Contributor
There was a problem hiding this comment.
- We should only
emitSnapshotupon main frame navigation to avoid spamming. - We have to remove the listener from the page/pages at some point.
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Aug 14, 2025
| page.mainFrame().on(Frame.Events.InternalNavigation, handleNavigation); | ||
| this._disposeListeners.push(() => page.mainFrame().off(Frame.Events.InternalNavigation, handleNavigation)); | ||
| }, | ||
| onPageClose: () => this._emitSnapshot(false), |
Contributor
There was a problem hiding this comment.
I think removing the listener here will stop retaining the page object and prevent a memory leak.
Member
Author
There was a problem hiding this comment.
done! it was hard to put it into here though because of scoping, so I put it into the the other one.
Member
Author
There was a problem hiding this comment.
scratch that - there's a difference between Close and Crash! I need to figure that out.
|
|
||
| private _trackHierarchyListener: InstrumentationListener | undefined; | ||
| private _reportState = false; | ||
| private _disposeListeners: (() => void)[] = []; |
Contributor
There was a problem hiding this comment.
Look into eventsHelper and RegisteredListener - perhaps those will come handy.
Member
Author
There was a problem hiding this comment.
Yeah I thought about those, but shoehorning instrumentation.addListener would've been difficult.
This comment has been minimized.
This comment has been minimized.
Skn0tt
force-pushed
the
debug-controller-report-browers
branch
from
833137f to
0a861aa
Compare
Contributor
Test results for "tests 1"3 failed 44 flaky46601 passed, 805 skipped Merge workflow run. |
dgozman
approved these changes
Aug 15, 2025
Skn0tt
added a commit
to Skn0tt/playwright
that referenced
this pull request
Oct 1, 2025
)" This reverts commit 58cab06.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for the browser list UI in VS Code, see #36732.