Skip to content

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Apr 14, 2025

We're still not ready with warnings (#35443) by 1.52 release. Disable for now.

@agg23 agg23 marked this pull request as ready for review April 14, 2025 17:08

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @webkit-ubuntu-22.04-node18

2 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:38:5 › should upload a folder @webkit-ubuntu-22.04-node18

39017 passed, 921 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests 1"

9 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node22-1
⚠️ [chromium] › headerView.spec.tsx:46:1 › should toggle filters @web-components-html-reporter
⚠️ [webkit-library] › library/screenshot.spec.ts:205:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1347:1 › should highlight locator in iframe while typing @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39023 passed, 921 skipped
✔️✔️✔️

Merge workflow run.

@agg23 agg23 merged commit 78600c6 into microsoft:main Apr 15, 2025
29 checks passed
agg23 added a commit to agg23/playwright that referenced this pull request Apr 15, 2025
agg23 added a commit that referenced this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants