fix(routeWebSocket): make sure ws url without trailing slash is supported #33095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
reviewed
Oct 14, 2024
This comment has been minimized.
This comment has been minimized.
dgozman
force-pushed
the
fix-route-ws-slash
branch
from
3cf3a34 to
e374c8a
Compare
mxschmitt
approved these changes
Oct 15, 2024
Test results for "tests 1"2 fatal errors, not part of any test 2 flaky35950 passed, 620 skipped, 1 did not run Merge workflow run. |
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Oct 15, 2024
…ithout trailing slash is supported
dgozman
added a commit
that referenced
this pull request
Oct 15, 2024
…ailing slash is supported (#33112)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33085.