Skip to content

test: mark permissions tests as flaky on Linux & Firefox #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2020
Merged

test: mark permissions tests as flaky on Linux & Firefox #1791

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d23bf4
test: mark permissions tests as flaky on Linux & Firefox
aslushnikov Apr 14, 2020
de2d4a8
nit
aslushnikov Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/permissions.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*/

const {FFOX, CHROMIUM, WEBKIT} = require('./utils').testOptions(browserType);
const {FFOX, CHROMIUM, WEBKIT, LINUX} = require('./utils').testOptions(browserType);

// Permissions API is not implemented in WebKit (see https://developer.mozilla.org/en-US/docs/Web/API/Permissions_API)
describe.skip(WEBKIT)('Permissions', function() {
Expand Down Expand Up @@ -82,7 +82,8 @@ describe.skip(WEBKIT)('Permissions', function() {
await context.clearPermissions();
expect(await getPermission(page, 'geolocation')).toBe('prompt');
});
it('should trigger permission onchange', async({page, server, context}) => {
//TODO: flaky on Linux. https://github.com/microsoft/playwright/pull/1790/checks?check_run_id=587327883
it.fail(FFOX && LINUX)('should trigger permission onchange', async({page, server, context}) => {
await page.goto(server.EMPTY_PAGE);
await page.evaluate(() => {
window['events'] = [];
Expand Down