test(interception): add redirect test, failing in webkit and firefox #1753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Apr 13, 2020
| expect(response.ok()).toBe(true); | ||
| expect(intercepted).toBe(true); | ||
| }); | ||
| // WebKit crashes. Firefox succeeds, but then fails to close. |
There was a problem hiding this comment.
I suspect failing to close might be unrelated issue, I've seen that in FF a few times.
| await page.goto(server.PREFIX + '/empty.html'); | ||
| await page.route('**/*', async(route, request) => { | ||
| if (request.url() !== server.PREFIX + '/redirect_this') | ||
| return route.continue(); |
There was a problem hiding this comment.
nit: why not page.route(server.PREFIX + '/redirect_this', ...) ?
debs-obrien
pushed a commit
to debs-obrien/playwright
that referenced
this pull request
Jun 10, 2025
Co-authored-by: microsoft-playwright-automation[bot] <203992400+microsoft-playwright-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebKit for linux crashes when we continue an intercepted request with a 301 redirect. I can't get a stack trace out of it. Happens with both gtk and wpe. I didn't test other operating systems.
Firefox passes the test, but after this test runs it hangs when calling
browserServer.close.Chromium works great.