fix(colorScheme): make light scheme default on all browsers #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
colorScheme
branch
2 times, most recently
from
f14c4f5 to
2ce745c
Compare
dgozman
approved these changes
Apr 6, 2020
docs/api.md
Outdated
| - `httpCredentials` <[Object]> Credentials for [HTTP authentication](https://developer.mozilla.org/en-US/docs/Web/HTTP/Authentication). | ||
| - `username` <[string]> | ||
| - `password` <[string]> | ||
| - `colorScheme` <"dark"|"light"|"no-preference"> Emulates `'prefers-colors-scheme'` media feature, supported values are `'light'`, `'dark'`, `'no-preference'`. See [page.emulateMedia(options)](#pageemulatemediaoptions) for more details. |
test/emulation.spec.js
Outdated
| it('should work in cross-process iframe', async({browser, server}) => { | ||
| const page = await browser.newPage({ colorScheme: 'dark' }); | ||
| await page.goto(server.EMPTY_PAGE); | ||
| await |
pavelfeldman
force-pushed
the
colorScheme
branch
from
a4155fe to
317673c
Compare
debs-obrien
pushed a commit
to debs-obrien/playwright
that referenced
this pull request
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1499