Skip to content

feat(chromium): support oopifs #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2020
Merged

feat(chromium): support oopifs #1664

merged 1 commit into from
Apr 6, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Apr 4, 2020

Splits CRPage into CRPage and FrameSession, carefully broadcasting or picking the right session for each operation.

References #1553.

pavelfeldman
pavelfeldman approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good. Could we add ~20 tests on the render swap? It'd be also cool if we could run many of our emulation tests against the iframe context.

@dgozman
feat(chromium): support oopifs
241ac9f 
Splits CRPage into CRPage and FrameSession, carefully broadcasting or
picking the right session for each operation.
@dgozman dgozman merged commit aeeac55 into microsoft:master Apr 6, 2020
debs-obrien pushed a commit to debs-obrien/playwright that referenced this pull request Jun 10, 2025
@playwrightmachine
feat(roll): roll to ToT Playwright (01-02-25) (microsoft#1664)
62295c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgozman @pavelfeldman