Skip to content

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Apr 3, 2020

References #1375.

Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that this is not going to help with the list if I'm reaching for an element in the shadow.

@dgozman dgozman merged commit a91304a into microsoft:master Apr 4, 2020
@thernstig
Copy link
Contributor

thernstig commented Apr 4, 2020

@dgozman @pavelfeldman Shouldn't the selector name be amended/updated with regards updated name attribute? E.g.:

const handle = await page.$('attribute=some-attribute');

@dgozman
Copy link
Contributor Author

dgozman commented Apr 6, 2020

@dgozman @pavelfeldman Shouldn't the selector name be amended/updated with regards updated name attribute? E.g.:

const handle = await page.$('attribute=some-attribute');

The name did not change, we still expose some predefined selectors like id=foo. They are just implemented as attribute selectors.

@thernstig
Copy link
Contributor

Understand, maybe it is a separate issue. I just think it is confusing to call it id when it selects attributes.

debs-obrien pushed a commit to debs-obrien/playwright that referenced this pull request Jun 10, 2025
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants