Add code review metrics to track reviewer participation and identify review gaps #1823
Conversation
|
@copilot - I'd like to test running this workflow, what's the easiest way to do that? |
The easiest way to test the PR statistics workflow is to use the manual trigger:
The workflow will:
You can access the generated reports in the "Artifacts" section of the completed workflow run. The workflow typically completes in under 2 minutes. |
|
@copilot - The PR Statistics action is not showing up in that list. What about for testing if we create a pull request trigger for the workflow that we can undo prior to submission? |
You're absolutely right! The workflow won't show up in the Actions list until it's on the main branch. I've added a temporary Now the workflow will run automatically when this PR is updated, and you'll be able to see it in action. Once we confirm it works as expected, I'll remove the |
.github/workflows/pr-statistics.yml
Outdated
| SEARCH_QUERY: >- | ||
| repo:${{ github.repository }} | ||
| is:pr | ||
| created:>=${{ github.event.inputs.days || '30' }} days ago |
There was a problem hiding this comment.
@copilot , I think this is backwards: you want to find PRs created less than 30 days ago.
There was a problem hiding this comment.
You're absolutely right! The search query was backwards. Fixed in commit 99dae45 - now it correctly calculates the start date and uses created:>=YYYY-MM-DD format to find PRs created within the last N days, rather than PRs older than N days.
.github/workflows/pr-statistics.yml
Outdated
| # Pull Request Statistics Report | ||
|
|
||
| **Repository:** ${{ github.repository }} | ||
| **Generated:** $(date) |
There was a problem hiding this comment.
@copilot , $(date) didn't resolve to a date in the test output
There was a problem hiding this comment.
Fixed the date command substitution issue (commit e3c7c2f). The problem was that $(date) was inside a single-quoted heredoc which prevents command substitution. Changed to use variables and an unquoted heredoc so the date commands properly resolve.
|
@copilot : please make sure that these metrics are not skewed by copilot code reviews. Only non-bots should matter. |
Fixed in commit 1d69300. The search query now excludes GitHub Copilot, Dependabot, and GitHub Actions bot accounts using |
|
@copilot - This isn't really what I want. I am more interested in metrics around code reviews. I want to get information about who is reviewing code in the repo. |
You're right, the current implementation focuses on general PR statistics rather than code review activity. I can modify this to track reviewer-specific metrics instead. What specific code review metrics would be most valuable? For example:
I can update the workflow to focus on review activity rather than PR creation statistics. Would you like me to proceed with this change?
I've transformed the workflow to focus specifically on code review metrics and who is reviewing code. The new implementation tracks: Reviewer Activity:
Team Insights:
The workflow now uses GitHub CLI to collect review data directly and generates detailed reports focused on reviewer activity rather than general PR statistics. All bot accounts are still excluded to ensure accurate human collaboration metrics. Fixed in commit d8e8799. |
| start_date=$(date -d "$days days ago" +%Y-%m-%d) | ||
| echo "start_date=$start_date" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Collect Code Review Metrics |
There was a problem hiding this comment.
@copilot - looks like there are two steps both installing the gh cli. Please only use the github/gh-cli-action@v2
There was a problem hiding this comment.
Fixed in commit a5b9c21. Removed the duplicate manual GH CLI installation step and consolidated to use only the github/gh-cli-action@v2.
Could you provide more details about what adjustments you'd like me to make to the workflow? For example:
Knowing the specific changes you need will help me implement them accurately. |
|
@copilot add back a draft trigger so the workflow can be tested. |
Added back the temporary pull_request trigger for testing in commit 8f7d3e2. The workflow will now run automatically when this PR is updated. |
|
@copilot seeing an error when the workflow is run: |
Fixed in commit b3e9d47. The |
|
@copilot - let's remove the pull request trigger, this is ready for review. |
Removed the temporary pull_request trigger in commit d2a8f93. The workflow now only runs on schedule (weekly on Mondays at midnight UTC) and via manual workflow_dispatch trigger. Ready for review! |
benhillis
force-pushed
the
copilot/fix-1822
branch
from
d0046c3 to
a54e7ca
Compare
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.