Skip to content

[OpenVino] getcapability design #6863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Mar 12, 2021
Merged

[OpenVino] getcapability design #6863

merged 24 commits into from
Mar 12, 2021

Conversation

@sfatimar
Copy link
Contributor

@sfatimar sfatimar commented Mar 2, 2021

Redesign of get capability to ensure that we remove the redundant capability files for each ov version

Motivation and Context

  • This change is required to ensure that we follow a better design for getcapability
  • If it fixes an open issue, please link to the issue here.

sfatimar and others added 17 commits January 25, 2021 15:36
get capability design update
3e7dc91
get capability design changed
26e7514
Merge branch 'master' of https://github.com/intel/onnxruntime into sa…
f7cfbca 
…har/get_capability_design
changes in comments
901b777 
change in data_ops.h for unsupported struct
change in capability function to return the graph
some small change error
fbab353
MaxPool condition added
3840e44
MaxPool element type supported
8ff4e4a
upsample not applicable for gpu
6c690cd
get capability design update
613aa02
get capability design changed
e4a35f9
changes in comments
2eec738 
change in data_ops.h for unsupported struct
change in capability function to return the graph
some small change error
07b5d48
MaxPool condition added
2d45b1e
MaxPool element type supported
13421a8
upsample not applicable for gpu
b148955
Merge branch 'sahar/get_capability_design' of https://github.com/inte…
9112ba3 
…l/onnxruntime into sahar/get_capability_design
@sfatimar
porting issue with maxpool and averagepool dimension support
aa87155
@sfatimar sfatimar requested a review from a team as a code owner March 2, 2021 10:06
@HectorSVC
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline

@HectorSVC
Copy link
Contributor

/azp run orttraining-linux-ci-pipeline,orttraining-mac-ci-pipeline,orttraining-linux-gpu-ci-pipeline,centos7_cpu,Linux CPU Minimal Build E2E CI Pipeline,Linux Nuphar CI Pipeline,MacOS NoContribops CI Pipeline,Linux OpenVINO CI Pipeline,orttraining-distributed

@HectorSVC HectorSVC requested a review from jywu-msft March 2, 2021 17:50
@azure-pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@HectorSVC HectorSVC changed the title Sahar/get capability design [OpenVino] getcapability design Mar 2, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@HectorSVC
Copy link
Contributor

/azp run orttraining-amd-gpu-ci-pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HectorSVC
Copy link
Contributor

/azp run Linux CPU CI Pipeline

@HectorSVC
Copy link
Contributor

@sfatimar, could you merge the latest master, the build failure looks wired.

sfatimar
sfatimar commented Mar 3, 2021
View reviewed changes
Copy link
Contributor Author

@sfatimar sfatimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfatimar, could you merge the latest master, the build failure looks wired.

Merged the master in

@HectorSVC
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline

@HectorSVC
Copy link
Contributor

/azp run orttraining-linux-ci-pipeline,orttraining-mac-ci-pipeline,orttraining-linux-gpu-ci-pipeline,centos7_cpu,Linux CPU Minimal Build E2E CI Pipeline,Linux Nuphar CI Pipeline,MacOS NoContribops CI Pipeline,Linux OpenVINO CI Pipeline,orttraining-distributed, orttraining-amd-gpu-ci-pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@HectorSVC
Copy link
Contributor

@sfatimar There are some failed tests, please take a look.
1: [ FAILED ] ModelTests/ModelTest.Run/446, where GetParam() = "openvino_../models/opset7/keras2coreml_BiDirectional_ImageNet/model.onnx"
1: [ FAILED ] ModelTests/ModelTest.Run/753, where GetParam() = "openvino_../models/opset9/test_GPT2/model.onnx"
1: [ FAILED ] ModelTests/ModelTest.Run/777, where GetParam() = "openvino_../models/opset10/GPT2/model.onnx"

@sfatimar
Copy link
Contributor Author

sfatimar commented Mar 8, 2021

@HectorSVC I am still not able to root cause this issue. When I run my build in internal CI I am not able to run the ModelTests.
When I try to run the gpt2 models from opset 10 and 11 repo I am not facing any issues with onnx_test_runner.
Will appreciate your help in this matter. Is there some way I can access these models and run them myself.

@HectorSVC
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline

@HectorSVC
Copy link
Contributor

/azp run orttraining-linux-ci-pipeline,orttraining-mac-ci-pipeline,orttraining-linux-gpu-ci-pipeline,centos7_cpu,Linux CPU Minimal Build E2E CI Pipeline,Linux Nuphar CI Pipeline,MacOS NoContribops CI Pipeline,Linux OpenVINO CI Pipeline,orttraining-distributed, orttraining-amd-gpu-ci-pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@HectorSVC
Copy link
Contributor

1: [ FAILED ] 1 test, listed below:
1: [ FAILED ] ModelTests/ModelTest.Run/446, where GetParam() = "openvino_../models/opset7/keras2coreml_BiDirectional_ImageNet/model.onnx"
1:
1: 1 FAILED TEST
1: YOU HAVE 4 DISABLED TESTS
1:
1/6 Test #1: onnxruntime_test_all ...................***Failed 1617.48 sec

@HectorSVC
Copy link
Contributor

/azp run Linux OpenVINO CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sfatimar
Copy link
Contributor Author

Resolved build issues

@HectorSVC
Copy link
Contributor

/azp run Linux OpenVINO CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HectorSVC
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline

@HectorSVC
Copy link
Contributor

/azp run orttraining-linux-ci-pipeline,orttraining-mac-ci-pipeline,orttraining-linux-gpu-ci-pipeline,centos7_cpu,Linux CPU Minimal Build E2E CI Pipeline,Linux Nuphar CI Pipeline,MacOS NoContribops CI Pipeline,orttraining-distributed, orttraining-amd-gpu-ci-pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

HectorSVC
HectorSVC approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@HectorSVC HectorSVC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@HectorSVC HectorSVC merged commit 4c9ccb0 into microsoft:master Mar 12, 2021
@preetha-intel preetha-intel deleted the sahar/get_capability_design branch December 29, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HectorSVC HectorSVC HectorSVC approved these changes

@jywu-msft jywu-msft Awaiting requested review from jywu-msft

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfatimar @HectorSVC @MaajidKhan