Skip to content

Conversation

yufenglee
Copy link
Member

@yufenglee yufenglee commented Mar 6, 2020

Publish release symbols (#3152)
Disable delayload for cuda dlls (#3147)
Update Gelu Fusion to support new graph pattern from PyTorch 1.4 (#3148)

tiagoshibata and others added 2 commits March 6, 2020 09:27
* Publish release symbols

* Publish symbols if IsReleaseBuild
This change fixes #3129. When running onnxruntime as dll on Windows, CUDA does some internal cleanups when process exits. After this, any call to CUDA would cause crash. Delayload makes thread_local destructor to happen after CUDA cleanup, thus the crash.
@yufenglee yufenglee requested review from jignparm and snnn March 6, 2020 17:30
@yufenglee yufenglee requested a review from a team as a code owner March 6, 2020 17:30
@yufenglee yufenglee requested a review from pranavsharma March 6, 2020 17:30
jywu-msft
jywu-msft previously approved these changes Mar 6, 2020
* update GeluFusion to support pattern from PyTorch 1.4; 
* Fix a bug that missing the check of an edge between mul2 and root.
* update script to fuse gelu from PyTorch 1.4
* Add test for python optimizer
@yufenglee yufenglee changed the title Cherry pick 2 fixes to rel-1.2.0 Cherry pick 3 fixes to rel-1.2.0 Mar 6, 2020
@yufenglee yufenglee requested a review from tianleiwu March 6, 2020 18:28
@yufenglee yufenglee merged commit dacb42f into rel-1.2.0 Mar 7, 2020
@yufenglee yufenglee deleted the roli/rel-1.2.0 branch March 7, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants