-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Move provider tests to onnxruntime_provider_test
and enable use of plugin EPs
#25689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…) which doesn't exist
…viderFactoryForEpDevices() to new helper AddEpOptionsToSessionOptions()
This reverts commit 7d80c61.
…out a symbol not being found for OrtDevice::CPU. go figure.
…/test/optimizer to onnxruntime/test/util
… test. Thanks to Adrian for the suggestion.
onnxruntime_provider_test
and enable use of plugin EPsonnxruntime_provider_test
and enable use of plugin EPs
…rtvalue.h. can clean that up later.
Hey , just seeing this now @edgchen1 @snnn. The MIGraphX was using the pai_test_launcher.sh script in our CI so this has caused a build break for MIGraphX. We typically sync weekly to your Mainline and build against Onnxruntime to ensure MIGraphX EP builds off your main won't cause breaks. | Is there something else we should be using now here instead? Should we just run the test launcher directly? From what I can tell, it seems like the Onnxruntime_test_all binary still exists I think we just need to add a filter for excluded tests still? Is there a larger change here for builds/testing that we need to incorporate in our infrastructure? If so please let me know |
Sorry. I didn't find any existing usages in the repo, so I assumed it was fine to delete. You can add it back if you want. The main change is to move some tests from onnxruntime_test_all to a new test program, onnxruntime_provider_test. To get the same test coverage, you'd want to also run the new test program. You may need to adjust your test filters accordingly, e.g., if they match a test that got moved. |
Good to know. Sure I can add that back in but if I can just call in the same piece, I can adjust CI directly then if this is the case. |
I think this was used when there was MIGraphX EP/ROCm EP CI but that got removed recently and we're in the process of adding it back |
### Description Cherry-pick the following PRs into the ORT 1.23.1 branch: - Fix Attention GQA implementation on CPU - **MANUAL MERGE**: see #26057 - main merge date: Sept 15, 11:33am - pr: #25966 - commit: d530b29 - Address edge GetMemInfo edge cases - main merge date: Sept 16, 10:32am - pr: #26021 - commit: d251f3a - Implement new Python APIs - main merge date: Sept 17, 11:44am - pr: #25999 - commit: abc63e8 - MemcpyFromHost and MemcpyToHost support for plugin EPs - **MERGE CONFLICT** on file onnxruntime/test/optimizer/transpose_optimizer_test.cc. Conflicts with #25689 - main merge date: Sept 23, 10:42am - pr: #26088 - commit: 4545732 - [TRT RTX EP] Fix bug for generating the correct subgraph in GetCapability #26132 - main merge date: Sept 23, 8:54pm - pr: #26132 - commit: 72e56e7 ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> --------- Co-authored-by: Dmitri Smirnov <[email protected]> Co-authored-by: Edward Chen <[email protected]> Co-authored-by: Chi Lo <[email protected]>
Description
Move provider-specific unit tests that were formerly in
onnxruntime_test_all
to a new test program,onnxruntime_provider_test
. Notably, this includes the op tests which test different provider implementations.Enable some tests in
onnxruntime_provider_test
(those usingModelTester
orOpTester
) to use a plugin EP. The plugin EP usage is specified at runtime, so it is referred to as "dynamic". The dynamic plugin EP configuration can be specified with environment variableORT_UNIT_TEST_MAIN_DYNAMIC_PLUGIN_EP_CONFIG_JSON
.This is an example value for
ORT_UNIT_TEST_MAIN_DYNAMIC_PLUGIN_EP_CONFIG_JSON
. The test infrastructure will register the plugin EP library atpath/to/example_plugin_ep.dll
. The op tests will use a plugin EP instance with the nameexample_ep
.Motivation and Context
Enable use of plugin EPs in some provider-specific unit tests.
Notes for Reviewers
#include
path updates.