-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Move moving weights to memory to the end of Graph::Resolve() #25626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…inject so it copies data into TensorProto
is the test failure real or a flakey test? [----------] 3 tests from WriteScores |
This appears to be real. I am getting help with NNAPI. |
NNAPI makes use of Initializer class that handles all kinds of external initializers.
…thub.com/microsoft/onnxruntime into yuslepukhin/move_ortinitializers_resolve
### Description <!-- Describe your changes. --> Move moving weights to memory to the end of Graph::Resolve(). Modify Inject so it copies data into TensorProto according to the C API docs. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> TypeAndShape inference runs as a part of `Resolve()` and it unable to inspect and load the initializers that point to OrtValues at that time. We choose to move TensorProto to OrtValue conversion at the end of `Resolve()`. References: #25579
### Description <!-- Describe your changes. --> Move moving weights to memory to the end of Graph::Resolve(). Modify Inject so it copies data into TensorProto according to the C API docs. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> TypeAndShape inference runs as a part of `Resolve()` and it unable to inspect and load the initializers that point to OrtValues at that time. We choose to move TensorProto to OrtValue conversion at the end of `Resolve()`. References: #25579 Co-authored-by: Dmitri Smirnov <[email protected]>
Description
Move moving weights to memory to the end of Graph::Resolve().
Modify Inject so it copies data into TensorProto according to the C API docs.
Motivation and Context
TypeAndShape inference runs as a part of
Resolve()
and it unable to inspect and load the initializers that point to OrtValues at that time. We choose to move TensorProto to OrtValue conversion at the end ofResolve()
.References: #25579