-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Refactor code to prevent internal structure from leaking outside Graph class #25586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
yuslepukhin
wants to merge
41
commits into
main
Choose a base branch
from
yuslepukhin/get_initializers_api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+771
−309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix reshaping for external weights Fix Fusion Helper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can commit the suggested changes from lintrunner.
|
||
namespace onnxruntime { | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
wcy123
added a commit
to wcy123/onnxruntime
that referenced
this pull request
Jul 31, 2025
It is based on microsoft#25586, VitisAI EP needs to remove the usage of Graph::GetAllInitializedTensors This is the follow up action item after microsoft#25588.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
InitializersName
facad type that exposes some essential methods and transform iterator to expose only initializers names while keeping the internal container intact.GetAllInitializersNames()
GetAllInitializedTensors()
Motivation and Context
We want to regain flexibility of changing internal data structures that house initializers. Currently, the type is used all over the code base including EPs.