Skip to content

Refactor code to prevent internal structure from leaking outside Graph class #25586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 41 commits into
base: main
Choose a base branch
from

Conversation

yuslepukhin
Copy link
Member

Description

  • Provide new API that returns InitializersName facad type that exposes some essential methods and transform iterator to expose only initializers names while keeping the internal container intact.
  • Refactor code to use new Graph API GetAllInitializersNames()
  • Refactor code to remove usage of GetAllInitializedTensors()

Motivation and Context

We want to regain flexibility of changing internal data structures that house initializers. Currently, the type is used all over the code base including EPs.

Fix reshaping for external weights
Fix Fusion Helper
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.


namespace onnxruntime {


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

wcy123 added a commit to wcy123/onnxruntime that referenced this pull request Jul 31, 2025
It is based on microsoft#25586, VitisAI EP needs to remove the usage of Graph::GetAllInitializedTensors

This is the follow up action item after microsoft#25588.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant