Skip to content

Fix SigLIP casual mask bug #25360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 15, 2025
Merged

Fix SigLIP casual mask bug #25360

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f87251a
Fix SigLIP casual mask bug
nenad1002 Jul 10, 2025
487c5ff
Check causal_mask_nodes
nenad1002 Jul 11, 2025
919ee48
Move causal mask nodes outside local scope
nenad1002 Jul 12, 2025
b991613
Move causal mask nodes outside local scope
nenad1002 Jul 12, 2025
e8884cf
Add a new test
nenad1002 Jul 15, 2025
49af722
Update onnxruntime/test/python/transformers/test_phi_vision.py
nenad1002 Jul 15, 2025
fc8f467
Update onnxruntime/test/python/transformers/test_phi_vision.py
nenad1002 Jul 15, 2025
1cec7b6
Update onnxruntime/test/python/transformers/test_phi_vision.py
nenad1002 Jul 15, 2025
7a633be
Update onnxruntime/test/python/transformers/test_phi_vision.py
nenad1002 Jul 15, 2025
fb36760
Trigger CLA check
nenad1002 Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion onnxruntime/python/tools/transformers/fusion_attention_clip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ def fuse(self, normalize_node, input_name_to_nodes, output_name_to_node):
output=attention_last_node.output[0],
add_qk_str=add_qk,
scale=None,
causal=(add_mask is not None),
causal=False,
)
if new_node is None:
logger.debug("fuse_attention: failed to create fused node")
Expand Down
Loading