[ROCm EP]Add ROCm execution provider to excluded EP for test with Cuda EP #24961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need this since ROCm EP just hipifies the CUDA kernel's used for this. Will give false failures when in fact CUDA EP is doing the same thing
|
@tianleiwu, this is a simple one line change. Just adds ROCm EP to the additional Exclude for this test case |
|
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline |
tianleiwu
approved these changes
Jun 5, 2025
|
Azure Pipelines successfully started running 5 pipeline(s). |
javier-intel
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Jun 15, 2025
…a EP (microsoft#24961) Need this since ROCm EP just hipifies the CUDA kernel's used for this. Will give false failures when in fact CUDA EP is doing the same thing ### Description <!-- Describe your changes. --> Adds ROCmExecutionprovider as additional exclude on test that CudaExecutionProvider is failing on. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Since ROCm EP performs a HIPIFY on the CUDA EP kernels to use the equivalent functionality in ROCm to achieve inference, any errors or gaps we find in the CUDA ep will translate accordingly to the ROCm EP. Need to add the exclude here to this newly added test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need this since ROCm EP just hipifies the CUDA kernel's used for this. Will give false failures when in fact CUDA EP is doing the same thing
Description
Adds ROCmExecutionprovider as additional exclude on test that CudaExecutionProvider is failing on.
Motivation and Context
Since ROCm EP performs a HIPIFY on the CUDA EP kernels to use the equivalent functionality in ROCm to achieve inference, any errors or gaps we find in the CUDA ep will translate accordingly to the ROCm EP. Need to add the exclude here to this newly added test