Skip to content

Conversation

@Zhaeong
Copy link
Contributor

@Zhaeong Zhaeong commented Apr 26, 2025

Description

This changes the naming of 'migraphx' EP to 'amdgpu'

Motivation and Context

For easier usability

@Zhaeong Zhaeong marked this pull request as draft April 26, 2025 01:11
@snnn snnn marked this pull request as ready for review April 26, 2025 02:35
@snnn snnn marked this pull request as draft April 26, 2025 02:35
@snnn
Copy link
Member

snnn commented Apr 26, 2025

/azp where

@@ -0,0 +1,106 @@
// Copyright (c) Microsoft Corporation. All rights reserved.

Check warning

Code scanning / lintrunner

CLANGFORMAT/format Warning

See https://clang.llvm.org/docs/ClangFormat.html.
Run lintrunner -a to apply this patch.
@@ -0,0 +1,24 @@
// Copyright 2019 AMD AMDAMDGPU

Check warning

Code scanning / lintrunner

CLANGFORMAT/format Warning

See https://clang.llvm.org/docs/ClangFormat.html.
Run lintrunner -a to apply this patch.
args.enable_training_ops = True

if args.use_migraphx:
warnings.warn("The use of --use_migraphx is deprecated. Please use --use_amdgpu instead.", UserWarning)

Check failure

Code scanning / lintrunner

RUFF/F821 Error

@snnn snnn marked this pull request as ready for review April 29, 2025 23:05
@karim-vad
Copy link
Contributor

Hi,
Thank you for the PR. Recently Adrian and I refactored some of the Generic Interface handling in the ORT main branch which is currently being cherry-picked to release. #24552.

Once above changes are available in release branch, we should rebase this PR on top of the latest release which will simplify a lot of Generic interface changes.

In summary

  • we have introduced separate macros for code that needs to be compiled as part of ORT interface i.e. e.g. DUSE_VITISAI_PROVIDER_INTERFACE.
  • If code being compiled belongs to both the ORT interface as well as part of EP, then code block should be wrapped by preprocessor # if USE_VITISAI_PROVIDER_INTERFACE || USE_VITISAI.
  • Please refer PR 24552 to see how changes were made.

@nieubank
Copy link
Contributor

nieubank commented May 5, 2025

Hi, Thank you for the PR. Recently Adrian and I refactored some of the Generic Interface handling in the ORT main branch which is currently being cherry-picked to release. #24552.

Once above changes are available in release branch, we should rebase this PR on top of the latest release which will simplify a lot of Generic interface changes.

In summary

  • we have introduced separate macros for code that needs to be compiled as part of ORT interface i.e. e.g. DUSE_VITISAI_PROVIDER_INTERFACE.
  • If code being compiled belongs to both the ORT interface as well as part of EP, then code block should be wrapped by preprocessor # if USE_VITISAI_PROVIDER_INTERFACE || USE_VITISAI.
  • Please refer PR 24552 to see how changes were made.

Can you retarget this to main?

@tianleiwu
Copy link
Contributor

@TedThemistokleous, please take a look.

@TedThemistokleous
Copy link
Contributor

TedThemistokleous commented May 7, 2025

@tianleiwu @Zhaeong

Why is this even being done? I thought AMD is maintaining the MIGraphX EP, furthermore changing the name after we're written documentation will cause confusion and issues. Its clear to a user if they want to leverage MIGraphX they'll be using the MIGraphX EP, which is the same MIGraphX that a customer gets who runs on a desktop, or a high end server.

cc @causten @ytaous

@Zhaeong Zhaeong marked this pull request as draft May 7, 2025 20:53
@Zhaeong Zhaeong closed this May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants