-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Change MigraphX EP to amdgpu EP #24565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change MigraphX EP to amdgpu EP #24565
Conversation
|
/azp where |
| @@ -0,0 +1,106 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
Check warning
Code scanning / lintrunner
CLANGFORMAT/format Warning
Run lintrunner -a to apply this patch.
| @@ -0,0 +1,24 @@ | |||
| // Copyright 2019 AMD AMDAMDGPU | |||
Check warning
Code scanning / lintrunner
CLANGFORMAT/format Warning
Run lintrunner -a to apply this patch.
| args.enable_training_ops = True | ||
|
|
||
| if args.use_migraphx: | ||
| warnings.warn("The use of --use_migraphx is deprecated. Please use --use_amdgpu instead.", UserWarning) |
Check failure
Code scanning / lintrunner
RUFF/F821 Error
See https://docs.astral.sh/ruff/rules/undefined-name
|
Hi, Once above changes are available in release branch, we should rebase this PR on top of the latest release which will simplify a lot of Generic interface changes. In summary
|
Can you retarget this to main? |
|
@TedThemistokleous, please take a look. |
|
Why is this even being done? I thought AMD is maintaining the MIGraphX EP, furthermore changing the name after we're written documentation will cause confusion and issues. Its clear to a user if they want to leverage MIGraphX they'll be using the MIGraphX EP, which is the same MIGraphX that a customer gets who runs on a desktop, or a high end server. |
Description
This changes the naming of 'migraphx' EP to 'amdgpu'
Motivation and Context
For easier usability