Skip to content

Fix spellchecks from Optional Lint #22802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Fix spellchecks from Optional Lint #22802

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49e54f6
fix spellcheck github action
jchen351 Nov 11, 2024
41fc396
Make PACKAGE_LIST into an array
jchen351 Nov 11, 2024
cb9783b
Make PACKAGE_LIST into an array
jchen351 Nov 11, 2024
d74ea9c
Merge branch 'main' into Cjian/spellcheck
jchen351 Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 62 additions & 50 deletions tools/ci_build/github/linux/docker/scripts/install_ubuntu.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ do case "${parameter_Option}"
in
p) PYTHON_VER=${OPTARG};;
d) DEVICE_TYPE=${OPTARG};;
*) echo "Usage: $0 -p PYTHON_VER -d DEVICE_TYPE";;
esac
done

Expand All @@ -20,86 +21,97 @@ apt-get update && apt-get install -y software-properties-common lsb-release

OS_VERSION=$(lsb_release -r -s)

PACKAGE_LIST="autotools-dev \
automake \
build-essential \
git apt-transport-https apt-utils \
ca-certificates \
pkg-config \
wget \
zlib1g \
zlib1g-dev \
libssl-dev \
curl libcurl4-openssl-dev \
autoconf \
sudo \
gfortran \
python3-dev \
language-pack-en \
liblttng-ust-dev \
libcurl4 \
libkrb5-3 \
libtinfo-dev \
libtinfo5 \
libtool \
openssh-server \
aria2 \
bzip2 \
unzip \
zip \
rsync libunwind8 libpng-dev libexpat1-dev \
python3-setuptools python3-numpy python3-wheel python3-pip python3-pytest python3-distutils \
openjdk-17-jdk \
graphviz"


if [ $DEVICE_TYPE = "Normal" ]; then
PACKAGE_LIST="$PACKAGE_LIST libedit-dev libxml2-dev python3-packaging"
PACKAGE_LIST=(
"apt-transport-https"
"apt-utils"
"aria2"
"autoconf"
"automake"
"autotools-dev"
"build-essential"
"bzip2"
"ca-certificates"
"curl"
"gfortran"
"git"
"graphviz"
"language-pack-en"
"libcurl4"
"libcurl4-openssl-dev"
"libexpat1-dev"
"libkrb5-3"
"liblttng-ust-dev"
"libpng-dev"
"libssl-dev"
"libtinfo-dev"
"libtinfo5"
"libtool"
"libunwind8"
"openjdk-17-jdk"
"openssh-server"
"pkg-config"
"python3-dev"
"python3-distutils"
"python3-numpy"
"python3-pip"
"python3-pytest"
"python3-setuptools"
"python3-wheel"
"rsync"
"sudo"
"unzip"
"wget"
"zip"
"zlib1g"
"zlib1g-dev"
)
if [ "$DEVICE_TYPE" = "Normal" ]; then
PACKAGE_LIST+=("libedit-dev" "libxml2-dev" "python3-packaging")
fi

PACKAGE_LIST="$PACKAGE_LIST libicu-dev"
PACKAGE_LIST+=("libicu-dev")

apt-get install -y --no-install-recommends $PACKAGE_LIST
apt-get install -y --no-install-recommends "${PACKAGE_LIST[@]}"

locale-gen en_US.UTF-8
update-locale LANG=en_US.UTF-8

if [ "$OS_VERSION" = "20.04" ]; then
# The defaul version of python is 3.8
major=$(echo $PYTHON_VER | cut -d. -f1)
minor=$(echo $PYTHON_VER | cut -d. -f2)
major=$(echo "$PYTHON_VER" | cut -d. -f1)
minor=$(echo "$PYTHON_VER" | cut -d. -f2)
if [ "$major" -lt 3 ] || [ "$major" -eq 3 ] && [ "$minor" -lt 8 ]; then
PYTHON_VER="3.8"
fi
if [ "$PYTHON_VER" != "3.8" ]; then
add-apt-repository -y ppa:deadsnakes/ppa
apt-get update
apt-get install -y --no-install-recommends \
python${PYTHON_VER} \
python${PYTHON_VER}-dev
update-alternatives --install /usr/bin/python3 python3 /usr/bin/python${PYTHON_VER} 1
python"${PYTHON_VER}" \
python"${PYTHON_VER}-"dev
update-alternatives --install /usr/bin/python3 python3 /usr/bin/python"${PYTHON_VER}" 1
update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.8 2
update-alternatives --set python3 /usr/bin/python${PYTHON_VER}
update-alternatives --set python3 /usr/bin/python"${PYTHON_VER}"
#TODO: the old one(/usr/bin/pip3) should be uninstalled first. Because the one will be
#put at /usr/local/. Then there will be two pips.
/usr/bin/python${PYTHON_VER} -m pip install --upgrade --force-reinstall pip==19.0.3
/usr/bin/python"${PYTHON_VER}" -m pip install --upgrade --force-reinstall pip==19.0.3
fi
elif [ "$OS_VERSION" = "22.04" ] ; then
# The defaul version of python is 3.10
major=$(echo $PYTHON_VER | cut -d. -f1)
minor=$(echo $PYTHON_VER | cut -d. -f2)
major=$(echo "$PYTHON_VER" | cut -d. -f1)
minor=$(echo "$PYTHON_VER" | cut -d. -f2)
if [ "$major" -lt 3 ] || [ "$major" -eq 3 ] && [ "$minor" -lt 10 ]; then
PYTHON_VER="3.10"
fi
if [ "$PYTHON_VER" != "3.10" ]; then
add-apt-repository -y ppa:deadsnakes/ppa
apt-get update
apt-get install -y --no-install-recommends \
python${PYTHON_VER} \
python${PYTHON_VER}-dev
update-alternatives --install /usr/bin/python3 python3 /usr/bin/python${PYTHON_VER} 1
python"${PYTHON_VER}" \
python"${PYTHON_VER}"-dev
update-alternatives --install /usr/bin/python3 python3 /usr/bin/python"${PYTHON_VER}" 1
update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.10 2
update-alternatives --set python3 /usr/bin/python${PYTHON_VER}
update-alternatives --set python3 /usr/bin/python"${PYTHON_VER}"
fi
else
exit 1
Expand Down
Loading